Skip to content

Correctly Configure Docker Node Pinning - #6712

Merged
FireLemons merged 3 commits into
rubyforgood:mainfrom
FireLemons:better_node_version_pinning
Feb 13, 2026
Merged

FireLemons merged 3 commits into
rubyforgood:mainfrom
FireLemons:better_node_version_pinning

Conversation

@FireLemons

Copy link
Copy Markdown
Collaborator

Relying on the ruby alpine image for node does not allow us to specify which major version we use. It was the solution for a while because the version of node we wanted just happened to be the same as the node from that image.

Currently we are using an old solution that does allow for custom node version in our image. However the repo we are getting node from is the latest alpine image which has a version of node that updates somewhat frequently which makes the method of pinning in this solution cause a conflict as soon as it updates.

@FireLemons
FireLemons marked this pull request as draft February 12, 2026 16:47
@FireLemons
FireLemons force-pushed the better_node_version_pinning branch 2 times, most recently from 8566cca to 38e80b7 Compare February 12, 2026 22:33
@FireLemons

Copy link
Copy Markdown
Collaborator Author

@stefannibrasil we had an incorrect docker config. Just wanted to ping you in case you picked up some bad info from working on it earlier

@github-actions github-actions Bot added the dependencies Touches dependency files label Feb 12, 2026
@FireLemons
FireLemons force-pushed the better_node_version_pinning branch from 418ba28 to f329145 Compare February 12, 2026 23:15
@stefannibrasil

Copy link
Copy Markdown
Contributor

oh, interesting, thanks for the heads up. What error were you getting?

@FireLemons
FireLemons force-pushed the better_node_version_pinning branch 2 times, most recently from ff79397 to c487f59 Compare February 13, 2026 02:18
@github-actions github-actions Bot added the ruby Touches Ruby code label Feb 13, 2026
@FireLemons
FireLemons force-pushed the better_node_version_pinning branch 11 times, most recently from d4a3340 to 5ec002f Compare February 13, 2026 03:54
@stefannibrasil

Copy link
Copy Markdown
Contributor

@FireLemons I see new PRs are broken now, sorry about that! Do you want to maybe revert #6708 and I can take a look? Weird that CI was green when that one was merged.

@FireLemons
FireLemons force-pushed the better_node_version_pinning branch from 5ec002f to 2ab77af Compare February 13, 2026 04:43
@FireLemons

Copy link
Copy Markdown
Collaborator Author

@stefannibrasil I meant that pinning node that way in our Dockerfile is suboptimal and you shouldn't do it in other places like that

@FireLemons
FireLemons force-pushed the better_node_version_pinning branch 2 times, most recently from 88174cd to a0899bd Compare February 13, 2026 05:07
@FireLemons
FireLemons force-pushed the better_node_version_pinning branch from a0899bd to 7e3c019 Compare February 13, 2026 05:25
@FireLemons
FireLemons marked this pull request as ready for review February 13, 2026 05:41
@FireLemons
FireLemons merged commit 0621783 into rubyforgood:main Feb 13, 2026
11 checks passed
@FireLemons

Copy link
Copy Markdown
Collaborator Author

Turns out the solution was just to copy the binaries from the node image. I spent a long time tying to copy just the built assets from a build step before remembering the docker image requires node and npm because it's a development environment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Touches dependency files ruby Touches Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants